Update dlsof.h for Solaris NFS rnode4.h issues#342
Merged
jiegec merged 1 commit intolsof-org:masterfrom Dec 15, 2025
Merged
Conversation
Member
|
Let's merge this first, until someone comes up with a better solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #334 issue on Solaris systems.
I would normally want a successful repo build before submitting PR. However, following the normal source instructions provided via a repo clone do not give me the ability to make a full build for
lsoffrom themasterbranch then. It looks like aMakefileissue not including all paths and pre-reqs under Solaris. That is a complete other issue.That said, the latest Release builds properly with this fix in place even if the github clone build fails. This alternative is better than providing a "corrected" rnode4.h as outlined in #334 .
I feel I am missing another way to solve this with a more elaborate fix, but due to a lack of time, I am providing this as-is until someone else can evaluate the validity of this "solution." My apologies ahead of time if I did not think further outside of the box and come up with a better solution.
Regards,
-Nic